Homec4science

Rename "IDPaged" to "CursorPaged", "executeWithPager" to "executeWith…

Authored by epriestley <git@epriestley.com> on Aug 7 2012, 20:54.

Description

Rename "IDPaged" to "CursorPaged", "executeWithPager" to "executeWith[Cursor|Offset]Pager"

Summary:
I'm trying to make progress on the policy/visibility stuff since it's a blocker for Wikimedia.

First, I want to improve Projects so they can serve as policy groups (e.g., an object can have a visibility policy like "Visible to: members of project 'security'"). However, doing this without breaking anything or snowballing into a bigger change is a bit awkward because Projects are name-ordered and we have a Conduit API which does offset paging. Rather than breaking or rewriting this stuff, I want to just continue offset paging them for now.

So I'm going to make PhabricatorPolicyQuery extend PhabricatorOffsetPagedQuery, but can't currently since the executeWithPager methods would clash. These methods do different things anyway and are probably better with different names.

This also generally improves the names of these classes, since cursors are not necessarily IDs (in the feed case, they're "chronlogicalKeys", for example). I did leave some of the interals as "ID" since calling them "Cursor"s (e.g., setAfterCursor()) seemed a little wrong -- it should maybe be setAfterCursorPosition(). These APIs have very limited use and can easily be made more consistent later.

Test Plan: Browsed around various affected tools; any issues here should throw/fail in a loud/obvious way.

Reviewers: vrana, btrahan

Reviewed By: vrana

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D3177

Details

Committed
epriestley <git@epriestley.com>Aug 7 2012, 20:54
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8ab178932903: Improve displaying of very large commits
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHed4a155c9168: Rename "IDPaged" to "CursorPaged", "executeWithPager" to "executeWith… (authored by epriestley <git@epriestley.com>).Aug 7 2012, 20:54