Homec4science

Don't atomize closures

Authored by Eric Stern <eric@ericstern.com> on Jul 1 2014, 15:16.

Description

Don't atomize closures

Summary: In a PHP5.3+ codebase with closures, Diviner would pick up anonymous functions and add them into the generated documentation. This causes them to be skipped.

Test Plan: Ran bin/diviner generate --clean before and after change, no longer got a bunch of unnamed functions dumped into the documentation.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9786

Details

Committed
epriestley <git@epriestley.com>Jul 1 2014, 16:47
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7304e29dec33: Various minor JSHint fixes.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHede6947dd1ef: Don't atomize closures (authored by Eric Stern <eric@ericstern.com>).Jul 1 2014, 16:47