Homec4science

Convert some loadPreferences() to getUserSetting()

Authored by epriestley <git@epriestley.com> on Jun 1 2016, 22:59.

Description

Convert some loadPreferences() to getUserSetting()

Summary:
Ref T4103. This doesn't get everything, but takes care of most of the easy stuff.

The tricky-ish bit here is that I need to move timezones, pronouns and translations to proper settings. I expect to pursue that next.

Test Plan:

  • Grepped for loadPreferences to identify callsites.
  • Changed start-of-week setting, loaded Calendar, saw correct start.
  • Visited welcome page, read "Adjust Settings" point.
  • Loaded Conpherence -- I changed behavior here slightly (switching threads drops the title glyph) but it wasn't consistent to start with and this seems like a good thing to push to the next version of Conpherence.
  • Enabled Filetree, toggled in Differential.
  • Disabled Filetree, no longer visible in Differential.
  • Changed "Unified Diffs" preference to "Small Screens" vs "Always".
  • Toggled filetree in Diffusion.
  • Edited a task, saw sensible projects in policy dropdown.
  • Viewed user profile, uncollapsed/collapsed side nav, reloaded page, sticky'd.
  • Toggled "monospaced textareas", used a comment box, got appropriate fonts.
  • Toggled durable column.
  • Disabled title glyphs.
  • Changed monospaced font to 18px/36px impact.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4103

Differential Revision: https://secure.phabricator.com/D16004

Details

Committed
epriestley <git@epriestley.com>Jun 2 2016, 15:29
Pushed
aubortJan 31 2017, 17:16
Parents
rPH9180f429eb9f: Provide a general-purpose, modular user cache for settings and other similar…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHedfc6a69345a: Convert some loadPreferences() to getUserSetting() (authored by epriestley <git@epriestley.com>).Jun 2 2016, 15:29