Homec4science

Fix several migration issues with the Task/Counter patch

Authored by epriestley <git@epriestley.com> on Nov 16 2012, 19:19.

Description

Fix several migration issues with the Task/Counter patch

Summary:
People hit three issues with D3914:

  • As per T2059, we applied a schema change from a .php patch, which currently does not work if you use a different user to make schema changes than for normal use.
    • Since the change in question is idempotent, just move it to a .sql patch. We'll follow up in T2059 and fix it properly.
  • Rogue daemons at several installs used old code (expecting autoincrement) to insert into the new table (no autoincrement), thereby creating tasks with ID 0.
    • Rename the table so they'll fail.
    • This also makes the code a little more consistent.
  • Some installs now have tasks with ID 0.
    • Use checks against null rather than against 0 so we can process these tasks.

The major issues this fixes are the schema upgrade failure in T2059, and the infinite loops in T2072 and elsewhere.

This isn't really a fully statisfactory fix. I'll discuss some next steps in T2072.

Test Plan: Created new tasks via MetaMTA/Differential. Ran tasks with phd debug taskmaster. Inserted a task 0 and verified it ran and archived correctly.

Reviewers: btrahan, vrana, nh

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2072, T2059

Differential Revision: https://secure.phabricator.com/D3973

Details

Committed
epriestley <git@epriestley.com>Nov 16 2012, 19:19
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe40bcc8d2bae: update documentation for storage changes w/ .php files
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHee2e85a0bb8d: Fix several migration issues with the Task/Counter patch (authored by epriestley <git@epriestley.com>).Nov 16 2012, 19:19