Homec4science

Make Herald transcripts policy-aware

Authored by epriestley <git@epriestley.com> on Oct 5 2013, 00:17.

Description

Make Herald transcripts policy-aware

Summary:
Ref T603. Herald transcripts potentially leak a bunch of content (task text, revision/commit content). Don't let users see them if they can't see the actual objects.

This is a little messy but ends up mostly reasonable-ish.

Test Plan:

  • Verified that transcripts for objects I couldn't see no longer appear in the list, and reject access.
  • Verified that transcripts for objects in applications I can't see reject access, albeit less gracefully.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D7221

Details

Committed
epriestley <git@epriestley.com>Oct 5 2013, 00:17
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa235768d586e: Modernize "Test Console" and fix a minor display bug with "Always"
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHee4bdb501b9b: Make Herald transcripts policy-aware (authored by epriestley <git@epriestley.com>).Oct 5 2013, 00:17