Homec4science

Use DifferentialRevisionQuery in differential controllers

Authored by Juan Pablo Civile <elementohb@gmail.com> on Jul 16 2013, 01:01.

Description

Use DifferentialRevisionQuery in differential controllers

Summary:
Change all instances of id(new DifferentialRevision())->load($id) for DifferentialRevisionQuery where reviewers are loaded.
Also make sure that the new reviewer status is being loaded so that all calls to getReviewers can be removed in the near future.

Test Plan: Use all three controllers with several revisions and check they still work in sane way

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T1279

Differential Revision: https://secure.phabricator.com/D6466

Details

Committed
epriestley <git@epriestley.com>Jul 16 2013, 01:01
Pushed
aubortJan 31 2017, 17:16
Parents
rPH10c9e387060a: Stop Phriction handling it's own Subscribers
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHee9fac5c8fb7: Use DifferentialRevisionQuery in differential controllers (authored by Juan Pablo Civile <elementohb@gmail.com>).Jul 16 2013, 01:01