Homec4science

Add abstract `getGroup()` method

Authored by Joshua Spence <josh@joshuaspence.com> on Feb 28 2015, 23:47.

Description

Add abstract getGroup() method

Summary: In D11722, a getGroup() method was added to all subclasses of PhabricatorApplicationConfigOptions, but no abstract method was added to the base class. This will fail if a custom *ConfigOptions class does not provide a getGroup() method, in which case $group->getGroup() (in PhabricatorConfigListController) will fatal.

Test Plan: N/A

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D11756

Details

Committed
Joshua Spence <josh@joshuaspence.com>Feb 28 2015, 23:47
Pushed
aubortJan 31 2017, 17:16
Parents
rPHea337abafb67: Minor tidying of `lipsum generate` workflow
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rPHeec2d145df03: Add abstract `getGroup()` method (authored by Joshua Spence <josh@joshuaspence.com>).Feb 28 2015, 23:47