Homec4science

Conpherence - support device in durable column

Authored by Bob Trahan <btrahan@phacility.com> on Mar 12 2015, 20:23.

Description

Conpherence - support device in durable column

Summary:
Ref T7014. This makes it so

  • you can't invoke the column from a device
  • if you are in desktop size and resize to tablet or phone, the column closes.
  • if you resize desktop -> device -> desktop, the column closes at device size and reopens at desktop size
  • if you load, then resize device -> desktop the column opens if the user has that preference
  • there is a brief flicker when you load on 'device' with the column open preference. it lasts as long as the js stack takes to calculate the device css rule.

Test Plan: see summary but i did stuff to do all that

Reviewers: chad, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7014

Differential Revision: https://secure.phabricator.com/D12052

Details

Committed
Bob Trahan <btrahan@phacility.com>Mar 12 2015, 20:23
Pushed
aubortJan 31 2017, 17:16
Parents
rPHf77c5c514b5d: Show shorter time in Conpherence, revisit spacing/colors
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPHeed10e47c9b5: Conpherence - support device in durable column (authored by Bob Trahan <btrahan@phacility.com>).Mar 12 2015, 20:23