Homec4science

Ensure Maniphest CC PHID list is always a list in maniphest.info

Authored by epriestley <git@epriestley.com> on Nov 16 2011, 18:21.

Description

Ensure Maniphest CC PHID list is always a list in maniphest.info

Summary: See T626. Use array_values() to discard keys, for consistency and so
this will always encode as a list (JSON array) over the wire.

Test Plan: Added and removed CCs from a task while calling maniphest.info on it;
CCs worked and I always received a list.

Reviewers: btrahan, jungejason, nh, tuomaspelkonen, aran

Reviewed By: aran

CC: skrul, aran, btrahan, epriestley

Differential Revision: 1118

Details

Committed
epriestley <git@epriestley.com>Nov 16 2011, 20:07
Pushed
aubortJan 31 2017, 17:16
Parents
rPH42383214ea1e: Enable admin to view and delete other users' herald rules
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHef020f711ef7: Ensure Maniphest CC PHID list is always a list in maniphest.info (authored by epriestley <git@epriestley.com>).Nov 16 2011, 20:07