Homec4science

Add order-by-ID to PhabricatorWorkerTriggerQuery

Authored by epriestley <git@epriestley.com> on Jan 20 2015, 01:55.

Description

Add order-by-ID to PhabricatorWorkerTriggerQuery

Summary:
Ref T6881. By design, the EXECUTION order only selects tasks which have been scheduled (since it performs a JOIN). This is inconsistent with other queries and problematic for withID/withPHID queries which may want to select an unscheduled task.

Switch to standard ID ordering by default.

Test Plan:

  • Instances console now finds unscheduled triggers.
  • Verified that all existing queries specify an explicit order.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T6881

Differential Revision: https://secure.phabricator.com/D11436

Details

Committed
epriestley <git@epriestley.com>Jan 20 2015, 01:55
Pushed
aubortJan 31 2017, 17:16
Parents
rPHcccdc488834a: Implement PhabricatorDestructibleInterface for event triggers
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHef106d297935: Add order-by-ID to PhabricatorWorkerTriggerQuery (authored by epriestley <git@epriestley.com>).Jan 20 2015, 01:55