Homec4science

Decrease fragility of `conpherence-pontificate` behavior

Authored by epriestley <git@epriestley.com> on Mar 31 2013, 23:41.

Description

Decrease fragility of conpherence-pontificate behavior

Summary:
Currently, this behavior binds a ton of IDs. This makes the behavior fragile: if it is invoked on a page without all the right elements, some JX.$() tends to explode.

Instead, don't assume anything is present on the page. This allows the behavior to be invoked on other pages (like the "New Conpherence" page) or pages without some elements (like some future thread-only mobile view) without creating JS errors.

Test Plan:
Added comments, added comments with files. Viewed "New conphenrece" page.

NOTE: Control+Enter is currently broken, but this diff didn't change that behavior.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D5468

Details

Committed
epriestley <git@epriestley.com>Mar 31 2013, 23:41
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe9fe1f4beb98: Make "New Conversation" a workflow dialog in Conpherence
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHef30820cf4d9: Decrease fragility of `conpherence-pontificate` behavior (authored by epriestley <git@epriestley.com>).Mar 31 2013, 23:41