Homec4science

Give users an explicit error if they try to upload a too-large diff to…

Authored by epriestley <git@epriestley.com> on Jan 9 2016, 03:44.

Description

Give users an explicit error if they try to upload a too-large diff to Differential

Summary:
Ref T8612. If a change affects more than 10K paths + hunks, tell the user it's too big and don't bother trying to write it. We're mostly bounded by INSERTs here.

Also, fix an issue with file upload errors. The keys are real PHP constants, but were accidentally converted to strings in D12797, causing every error to show as "unknown error".

Test Plan: {F1057509}

Reviewers: joshuaspence

Reviewed By: joshuaspence

Maniphest Tasks: T8612

Differential Revision: https://secure.phabricator.com/D14977

Details

Committed
epriestley <git@epriestley.com>Jan 9 2016, 03:53
Pushed
aubortJan 31 2017, 17:16
Parents
rPH2c293bdca88d: Fix a missed use of project icons in typehaeads
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHefba69a44022: Give users an explicit error if they try to upload a too-large diff to… (authored by epriestley <git@epriestley.com>).Jan 9 2016, 03:53