Homec4science

Load all diff properties in revision view

Authored by vrana <jakubv@fb.com> on Oct 10 2012, 21:25.

Description

Load all diff properties in revision view

Summary:
We need to load all properties with some prefix in one field.
We can't merge them in one property because there will be a race condition for update (we don't have API for load+update+save).

Instead of providing API for this and complicating the code even more, just load everything unconditionally.
It shouldn't waste much bandwith or memory because we use most of the properties anyway.
It also looked overengineered to me.

Test Plan: Displayed revision with fields using diff properties.

Reviewers: epriestley, royw

Reviewed By: royw

CC: aran, royw, Korvin

Differential Revision: https://secure.phabricator.com/D3676

Details

Committed
vrana <jakubv@fb.com>Oct 10 2012, 22:43
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd9c6e07f2c4e: If users are on the email to Phabricator, do not send them the Phabricator…
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPHefed12400d28: Load all diff properties in revision view (authored by vrana <jakubv@fb.com>).Oct 10 2012, 22:43