Homec4science

Prevent "Wait for Build Commits" from creating billions of logs

Authored by James Rhodes <jrhodes@redpointsoftware.com.au> on Aug 29 2014, 18:11.

Description

Prevent "Wait for Build Commits" from creating billions of logs

Summary:
Resolves T5987. This build step was at some point converted to use yielding, which meant that whenever the build step executes it will create a new log. This checks to see if there is an existing log before creating a new one and uses that instead.

Long term we're going to need some way of attaching data to PhabricatorWorkerYieldException that can be read when the build step starts again; this will allow us to move more build steps off while (...) { ... sleep(X); } loops and onto yielding.

Test Plan: Tested locally.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley

Maniphest Tasks: T5987

Differential Revision: https://secure.phabricator.com/D10383

Details

Committed
James Rhodes <jrhodes@redpointsoftware.com.au>Aug 29 2014, 18:11
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd1936711a077: Diffusion - replace last `hg manifest` call with `hg locate`
Branches
Unknown
Tags
Unknown

Event Timeline

James Rhodes <jrhodes@redpointsoftware.com.au> committed rPHf015cb50fe6a: Prevent "Wait for Build Commits" from creating billions of logs (authored by James Rhodes <jrhodes@redpointsoftware.com.au>).Aug 29 2014, 18:11