Homec4science

Improve error message for bad timestamps

Authored by epriestley <git@epriestley.com> on Aug 2 2013, 16:38.

Description

Improve error message for bad timestamps

Summary: Ref T3031. While we should probably do more than this, provide a more useful error message so I don't have to make users run date and such.

Test Plan:
Added || true and ran arc list:

$ arc list --conduit-uri=http://local.aphront.com:8080/
Exception
ERR-INVALID-TOKEN: The request you submitted is signed with a timestamp, but that timestamp is not within 15 m of the current time. The signed timestamp is 1375454102 (Fri, 02 Aug 2013 07:35:02 -0700), and the current server time is 1375454102 (Fri, 02 Aug 2013 07:35:02 -0700). This is a differnce of 0 seconds, but the timestamps must differ from the server time by no more than 900 seconds. Your client or server clock may not be set correctly.
(Run with --trace for a full exception trace.)

Reviewers: btrahan, chad

Reviewed By: chad

CC: aran

Maniphest Tasks: T3031

Differential Revision: https://secure.phabricator.com/D6653

Details

Committed
epriestley <git@epriestley.com>Aug 2 2013, 16:38
Pushed
aubortJan 31 2017, 17:16
Parents
rPH6c7f36f6b81b: Use filtered query instead of filter in Elasticsearch
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHf0857e4fd817: Improve error message for bad timestamps (authored by epriestley <git@epriestley.com>).Aug 2 2013, 16:38