Homec4science

Change/drop/reconcile some miscellaneous edit behaviors in Maniphest

Authored by epriestley <git@epriestley.com> on Dec 4 2015, 19:53.

Description

Change/drop/reconcile some miscellaneous edit behaviors in Maniphest

Summary:
Ref T9132. Open to discussion here since it's mostly product stuff, but here's my gut on this:

  • Change Maniphest behavior to stop assigning tasks if they're unassigned when closed. I think this behavior often doesn't make much sense. We'll probably separately track "who closed this" in T4434 eventually.
  • Only add the actor as a subscriber if they comment, like in other applications. Previously, we added them as a subscriber for other types of changes (like priority and status changes). This is more consistent, but open to retaining the old behavior or some compromise between the two.
  • Retain the "when changing owner, subscribe the old owner" behavior.

Test Plan:

  • Added a comment, got CC'd.
  • Changed owners, saw old owner get CC'd.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9132

Differential Revision: https://secure.phabricator.com/D14670

Details

Committed
epriestley <git@epriestley.com>Dec 5 2015, 01:29
Pushed
aubortJan 31 2017, 17:16
Parents
rPHf9e84d1a88af: Make "Assign / Claim" stacked action work properly in Maniphest
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHf1744ac6d9f8: Change/drop/reconcile some miscellaneous edit behaviors in Maniphest (authored by epriestley <git@epriestley.com>).Dec 5 2015, 01:29