Homec4science

Probably fix excessive "(authored by X)" attributions

Authored by epriestley <git@epriestley.com> on Feb 2 2015, 23:59.

Description

Probably fix excessive "(authored by X)" attributions

Summary:
This is a pain to test, but we do a lot of needless "X committed thing (authored by X)" right now.

I think that's because we compare two handle links here, and they're never the same, even if they're both links to the same object.

Instead, compare the author and committer more carefully.

Test Plan: Will do it live.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D11635

Details

Committed
epriestley <git@epriestley.com>Feb 2 2015, 23:59
Pushed
aubortJan 31 2017, 17:16
Parents
rPH4af1fd2a79bb: Aphlict - remove listeners when clients close the connection
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHf1b238cb42e9: Probably fix excessive "(authored by X)" attributions (authored by epriestley <git@epriestley.com>).Feb 2 2015, 23:59