Moved rendering to PholioInlineCommentView
f1bd1da06270
Actions

Authored by Lauri-Henrik Jalonen <ljalonen@cs.helsinki.fi> on Feb 19 2013, 23:12.

Description

Moved rendering to PholioInlineCommentView

Summary:
Rendering of inline comments has now been moved to PholioInlineCommentView controller.
Delete almost deletes and edit... well not so much, but replaced google.fi with amazing popup.

Test Plan: Verified that inline comments still show up. Verified that delete almost deletes.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2446

Differential Revision: https://secure.phabricator.com/D4994

Conflicts:

src/applications/pholio/controller/PholioInlineController.php

Details

Committed

epriestley <git@epriestley.com>

Feb 19 2013, 23:14

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPH8eb404aea781: Avoid HTML escaping in plain text e-mails

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHf1bd1da06270: Moved rendering to PholioInlineCommentView (authored by Lauri-Henrik Jalonen <ljalonen@cs.helsinki.fi>).Feb 19 2013, 23:14

Changes (11)

				Path
	M			src/__phutil_library_map__.php
	M			src/applications/pholio/application/PhabricatorApplicationPholio.php
	M			src/applications/pholio/controller/PholioInlineController.php
	A			src/applications/pholio/controller/PholioInlineDeleteController.php
	M			src/applications/pholio/controller/PholioInlineSaveController.php
	A			src/applications/pholio/controller/PholioInlineViewController.php
	M			src/applications/pholio/query/PholioMockQuery.php
	M			src/applications/pholio/storage/PholioImage.php
	A			src/applications/pholio/view/PholioInlineCommentView.php
	M			src/applications/pholio/view/PholioMockImagesView.php
	M			webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js