Homec4science

Improve subproject/milestone error handling for users who can't create projects

Authored by epriestley <git@epriestley.com> on Feb 15 2016, 16:20.

Description

Improve subproject/milestone error handling for users who can't create projects

Summary:
Fixes T10357.

  • Show a better (more descriptive) error message when a user who can't create projects tries to create a subproject or milestone.
  • Disable the subproject actions if you don't have create permission.

All this stuff was already enforced properly: this diff doesn't make any actual policy changes, just improves the UI for users who lack permission.

Test Plan:

  • As an unprivileged user (no "Can Create Projects"), tried to create a subproject or milestone.
  • After patch, got a disabled action, with more specific and helpful error than before.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10357

Differential Revision: https://secure.phabricator.com/D15274

Details

Committed
epriestley <git@epriestley.com>Feb 15 2016, 16:32
Pushed
aubortJan 31 2017, 17:16
Parents
rPH76ea67819f21: Add base colors as workboard color choices
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHf1f8ee8e6ad5: Improve subproject/milestone error handling for users who can't create projects (authored by epriestley <git@epriestley.com>).Feb 15 2016, 16:32