Return `$this` from setter methods
f2435fd1d0b5
Actions

Authored by Joshua Spence <josh@joshuaspence.com> on Jul 6 2015, 14:53.

Description

Return $this from setter methods

Summary: Return $this from setter methods for consistency. I started writing a linter rule to detect this, but I don't think it is trivial to do this properly.

Test Plan: Eyeball it.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D13422

Details

Committed

Joshua Spence <josh@joshuaspence.com>

Jul 6 2015, 14:53

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPHacb1eb81ccf4: Move some PhabricatorSearchField subclasses

Branches

Unknown

Tags

Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rPHf2435fd1d0b5: Return `$this` from setter methods (authored by Joshua Spence <josh@joshuaspence.com>).Jul 6 2015, 14:53

Changes (12)

				Path
	M			src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php
	M			src/applications/differential/parser/DifferentialChangesetParser.php
	M			src/applications/diviner/atom/DivinerAtom.php
	M			src/applications/legalpad/editor/LegalpadDocumentEditor.php
	M			src/applications/metamta/view/PhabricatorMetaMTAMailBody.php
	M			src/applications/paste/view/PasteEmbedView.php
	M			src/applications/releeph/editor/ReleephRequestTransactionalEditor.php
	M			src/applications/releeph/field/specification/ReleephFieldSpecification.php
	M			src/applications/releeph/field/specification/ReleephLevelFieldSpecification.php
	M			src/applications/repository/engine/PhabricatorRepositoryRefEngine.php
	M			src/applications/search/engine/PhabricatorApplicationSearchEngine.php
	M			src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php