Homec4science

Pholio - fix show older transactions for if there are inline comments

Authored by Bob Trahan <btrahan@phacility.com> on Dec 17 2014, 18:42.

Description

Pholio - fix show older transactions for if there are inline comments

Summary: We didn't load enough data for this case for the custom view class Pholio uses. Fixes T6770. Re-jiggers the signature of the loadImages function in the PholioMockQuery to get there so as to not duplicate any business logic.

Test Plan: made a pholio mock with lots of inline comments. pre-patch "show older" fatals and post-patch "show older" works

Reviewers: chad, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6770

Differential Revision: https://secure.phabricator.com/D11002

Details

Committed
Bob Trahan <btrahan@phacility.com>Dec 17 2014, 18:42
Pushed
aubortJan 31 2017, 17:16
Parents
rPHed4c7893e900: Fix a exception being thrown from Diviner
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPHf24ae96bb6e0: Pholio - fix show older transactions for if there are inline comments (authored by Bob Trahan <btrahan@phacility.com>).Dec 17 2014, 18:42