Homec4science

Issue a warning if `javelinsymbols` is not built

Authored by epriestley <git@epriestley.com> on May 11 2011, 14:11.

Description

Issue a warning if javelinsymbols is not built

Summary:
Currently, the Javelin linter fails completley if this binary is missing.
However, it's hard to build and not critical so just issue a warning.

Eventually we can document this better and make the build easier, but the
current behavior is pretty unfriendly so make it smoother until the state of the
world can be improved.

Test Plan:
Removed the binary and ran "arc lint --lintall" against multiple Javelin paths.
Received one warning. Restored the binary and ran with "--trace", got no
warnings and verified that the binary was running.

Reviewed By: jungejason
Reviewers: tuomaspelkonen, jungejason, aran, tomo
CC: aran, jungejason
Differential Revision: 265

Details

Committed
epriestley <git@epriestley.com>May 11 2011, 21:08
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc6beb7a4fbd0: Move to explicit initialization of PhutilErrorHandler.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHf36c852542e9: Issue a warning if `javelinsymbols` is not built (authored by epriestley <git@epriestley.com>).May 11 2011, 21:08