Allow "Default View" policies to be set to Public
f4582dc49d8d
Actions

Authored by epriestley <git@epriestley.com> on Oct 10 2013, 00:06.

Description

Allow "Default View" policies to be set to Public

Summary: Ref T603. Currently, we hard-code defense against setting policies to "Public" in several places, and special case only the CAN_VIEW policy. In fact, other policies (like Default View) should also be able to be set to public. Instead of hard-coding this, move it to the capability definitions.

Test Plan: Set default view policy in Maniphest to "Public", created a task, verified default policy.

Reviewers: btrahan, asherkin

Reviewed By: asherkin

CC: asherkin, aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D7276

Details

Committed

epriestley <git@epriestley.com>

Oct 10 2013, 00:06

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPH11fbd213b105: Custom Policy Editor

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHf4582dc49d8d: Allow "Default View" policies to be set to Public (authored by epriestley <git@epriestley.com>).Oct 10 2013, 00:06

Changes (7)

				Path
	M			src/applications/differential/capability/DifferentialCapabilityDefaultView.php
	M			src/applications/maniphest/capability/ManiphestCapabilityDefaultView.php
	M			src/applications/meta/controller/PhabricatorApplicationEditController.php
	M			src/applications/policy/capability/PhabricatorPolicyCapability.php
	M			src/applications/policy/capability/PhabricatorPolicyCapabilityCanView.php
	M			src/applications/policy/filter/PhabricatorPolicyFilter.php
	M			src/view/form/control/AphrontFormPolicyControl.php