Homec4science

Refactor some Herald code

Authored by Jason Ge <jungejason@fb.com> on Oct 22 2011, 03:34.

Description

Refactor some Herald code

Summary:
I was reading herald code for a task and realized that the method was
really long. So I refactor it to shorter methods.

Test Plan:
was still able to create a differential rule and commit rule; and
verified that dry-run still worked.

Reviewers: epriestley, tuomaspelkonen

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: 1077

Details

Committed
Jason Ge <jun.ge.jason@fb.com>Nov 5 2011, 00:32
Pushed
aubortJan 31 2017, 17:16
Parents
rPHfbfb263cd9ef: Provide a configuration flag to disable silliness in the UI
Branches
Unknown
Tags
Unknown

Event Timeline

Jason Ge <jun.ge.jason@fb.com> committed rPHf46e12d0ca81: Refactor some Herald code (authored by Jason Ge <jungejason@fb.com>).Nov 5 2011, 00:32