Homec4science

Fix an issue with incorrect authorization handling in Working Copy build steps

Authored by epriestley <git@epriestley.com> on Oct 30 2015, 17:02.

Description

Fix an issue with incorrect authorization handling in Working Copy build steps

Summary:
Fixes T9669. Two issues:

  • We were using repositoryPHIDs instead of blueprintPHIDs for the list of allowed blueprints. Use the correct value.
  • We weren't enforcing allowedBlueprintPHIDs fully correctly. We did require an authorization, so the net effect was correct in nearly all cases, but we could have selected from too large a pool in the case where the application itself was doing the authorization (e.g., from the command line).

Test Plan: Ran a build through Drydock/Harbormaster locally.

Reviewers: chad, tycho.tatitscheff

Reviewed By: chad, tycho.tatitscheff

Subscribers: tycho.tatitscheff

Maniphest Tasks: T9669

Differential Revision: https://secure.phabricator.com/D14368

Details

Committed
epriestley <autocommitter@example.com>Oct 30 2015, 17:02
Pushed
aubortJan 31 2017, 17:16
Parents
rPH096117aacded: Allow any {icon} to spin
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <autocommitter@example.com> committed rPHf48a8337048d: Fix an issue with incorrect authorization handling in Working Copy build steps (authored by epriestley <git@epriestley.com>).Oct 30 2015, 17:02