Homec4science

Add rough validation on email addresses

Authored by epriestley <git@epriestley.com> on Feb 24 2014, 02:31.

Description

Add rough validation on email addresses

Summary: Put a very rough filter on what we'll accept as an email address. We can expand this if anyone is actually using local delivery or other weird things. This is mostly to avoid a theoretical case where some input is parsed differently by PhutilAddressParser and the actual mail adapter, in some subtle hypothetical way. This should give us only "reasonable" email addresses which parsers would be hard-pressed to trip up on.

Test Plan: Added and executed unit tests. Tried to add silly emails. Added valid emails.

Reviewers: btrahan, arice

Reviewed By: arice

CC: arice, chad, aran

Differential Revision: https://secure.phabricator.com/D8320

Details

Committed
epriestley <git@epriestley.com>Feb 24 2014, 02:31
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa566ae373015: Require a CSRF code for Twitter and JIRA (OAuth 1) logins
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHf49470f9bf91: Add rough validation on email addresses (authored by epriestley <git@epriestley.com>).Feb 24 2014, 02:31