Homec4science

Don't skip policy checks on ObjectQuery if special capabilities are required

Authored by epriestley <git@epriestley.com> on Dec 18 2014, 02:04.

Description

Don't skip policy checks on ObjectQuery if special capabilities are required

Summary: Ref T6741. As an optimization, we omit policy checks on ObjectQuery, but need to retain them if the query requests non-view permissions. This primarily affected Almanac properties.

Test Plan: Almanac properties now do full policy checks on ObjectQuery loads.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T6741

Differential Revision: https://secure.phabricator.com/D11005

Details

Committed
epriestley <git@epriestley.com>Dec 18 2014, 02:04
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd8739459f6f9: Rename "Local" settings in Diffusion to "Storage"
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHf5600acb16f0: Don't skip policy checks on ObjectQuery if special capabilities are required (authored by epriestley <git@epriestley.com>).Dec 18 2014, 02:04