Homec4science

Clean up some ordering and strata edge cases in Phrequent

Authored by epriestley <git@epriestley.com> on Oct 22 2013, 01:58.

Description

Clean up some ordering and strata edge cases in Phrequent

Summary:
Ref T3569. Two issues:

  1. Since sort() is not stable, instantaneous events (ending on the same second they start) would sometime sort wrong and produce the wrong results. Guarantee they sort correctly.
  2. Because events can end at any time, there are some additional special cases the algorithm didn't handle properly. Draw a bunch of ASCII art diagrams so these cases work properly.

Test Plan:

  • No more fatal when tracking an object for the first time.
  • Unit tests.

Reviewers: btrahan

Reviewed By: btrahan

CC: skyronic, aran

Maniphest Tasks: T3569

Differential Revision: https://secure.phabricator.com/D7350

Details

Committed
epriestley <git@epriestley.com>Oct 22 2013, 01:58
Pushed
aubortJan 31 2017, 17:16
Parents
rPHda9a3621696b: Shuffle project information around on detail page
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHf5c7dd68d217: Clean up some ordering and strata edge cases in Phrequent (authored by epriestley <git@epriestley.com>).Oct 22 2013, 01:58