Homec4science

Fix Herald test adapter for commits

Authored by epriestley <git@epriestley.com> on Aug 17 2016, 17:34.

Description

Fix Herald test adapter for commits

Summary:
Fixes T11488. I broke this in D16360, I think by doing a little extra refactoring after testing it.

This code is very old, before commits always needed to have repositories attached in order to do policy checks.

Modernize it by mostly just using the repository which is present on the Commit object, and using the existing edge cache.

Test Plan: Ran a commit through the Herald test adapter.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11488

Differential Revision: https://secure.phabricator.com/D16413

Details

Committed
epriestley <git@epriestley.com>Aug 17 2016, 18:02
Pushed
aubortJan 31 2017, 17:16
Parents
rPHf46cf99274d1: Fix a typo in "Internationalization" documentation
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHf659b8743a01: Fix Herald test adapter for commits (authored by epriestley <git@epriestley.com>).Aug 17 2016, 18:02