Homec4science

Fix over-matching of quoted text for message bodies beginning with "On..."

Authored by epriestley <git@epriestley.com> on Dec 7 2013, 00:47.

Description

Fix over-matching of quoted text for message bodies beginning with "On..."

Summary:
A user sent a message to Phabricator which looked like:

On blah blah blah ?

On <date>, <user> wrote:
> blah blah blah

The current algorithm is too aggressive and thinks lines 1-3 are all the "On ... wrote:" string. Instead, patch only the most recent "On".

Test Plan: Added a failing test and made it pass.

Reviewers: btrahan, zeeg

Reviewed By: zeeg

CC: aran

Differential Revision: https://secure.phabricator.com/D7732

Details

Committed
epriestley <git@epriestley.com>Dec 7 2013, 00:47
Pushed
aubortJan 31 2017, 17:16
Parents
rPH3ad4be4d9377: Multicolor headers
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHf69793184e0b: Fix over-matching of quoted text for message bodies beginning with "On..." (authored by epriestley <git@epriestley.com>).Dec 7 2013, 00:47