Homec4science

Support thumbnailing non-image files and straighten out setup for 'gd'

Authored by epriestley <git@epriestley.com> on Jun 13 2011, 17:43.

Description

Support thumbnailing non-image files and straighten out setup for 'gd'

Summary:
Make 'gd' an explicit optional dependency, test for it in setup, and make the
software behave correctly if it is not available.

When generating file thumnails, provide reasonable defaults and behavior for
non-image files.

Test Plan:
Uploaded text files, pdf files, etc., and got real thumbnails instead of a
broken image.

Simulated setup and gd failures and walked through setup process and image
fallback for thumbnails.

Reviewed By: aran
Reviewers: toulouse, jungejason, tuomaspelkonen, aran
CC: aran, epriestley
Differential Revision: 446

Details

Committed
epriestley <git@epriestley.com>Jun 13 2011, 22:49
Pushed
aubortJan 31 2017, 17:16
Parents
rPHcb0cbc50ad0f: Add a "phd debug" command
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHf7060939330a: Support thumbnailing non-image files and straighten out setup for 'gd' (authored by epriestley <git@epriestley.com>).Jun 13 2011, 22:49