Homec4science

Don't use "/e" in PHPMailer Lite

Authored by epriestley <git@epriestley.com> on Apr 8 2012, 19:02.

Description

Don't use "/e" in PHPMailer Lite

Summary: PHP 5.4 raises an E_STRICT warning about "/e", and it's a generally awful idea, even though this case doesn't look exploitable. Silence the warning by using preg_replace_callback() instead of "/e".

Test Plan: Sent myself a message with a bunch of multibyte UTF8 characters in it, it came through cleanly.

Reviewers: btrahan, vrana, jungejason

Reviewed By: vrana

CC: aran

Maniphest Tasks: T1056

Differential Revision: https://secure.phabricator.com/D2147

Details

Committed
epriestley <git@epriestley.com>Apr 8 2012, 19:02
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb90d41dd907c: Add an "--ignore-duplicates" flag to import_project_symbols.php
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHf7b569e5d9b7: Don't use "/e" in PHPMailer Lite (authored by epriestley <git@epriestley.com>).Apr 8 2012, 19:02