Homec4science

Order actions sensibly within Differential revision comment action groups

Authored by epriestley <git@epriestley.com> on Dec 29 2016, 22:36.

Description

Order actions sensibly within Differential revision comment action groups

Summary:
Ref T11114. See D17114 for some discussion.

For review actions: accept, reject, resign.

For revision actions, order is basically least-severe to most-severe action pairs: plan changes, request review, close, reopen, abandon, reclaim, commandeer.

Test Plan: Viewed revisions as an author and a reviewer, saw sensible action order within action groups.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11114

Differential Revision: https://secure.phabricator.com/D17115

Details

Committed
epriestley <git@epriestley.com>Dec 31 2016, 19:10
Pushed
aubortJan 31 2017, 17:16
Parents
rPH48fcfeadafe2: Allow comment actions to be grouped; group Differential "Review" and "Revision"…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHf7b5955d3386: Order actions sensibly within Differential revision comment action groups (authored by epriestley <git@epriestley.com>).Dec 31 2016, 19:10