Homec4science

Add a friendlier "in flight" error page

Authored by epriestley <git@epriestley.com> on Sep 6 2016, 22:48.

Description

Add a friendlier "in flight" error page

Summary:
Ref T11589. When we hit a fatal setup issue (essentially always a connection failure) after we've already survived them on at least one request, we can be pretty sure a server went down and that the problem is not a setup/configuration issue.

In this case, show a friendlier error page instead of the fairly detailed technical one.

Test Plan:

  • Broke MySQL config.
  • Restarted Apache.
  • Got the "admin/setup" error page:

{F1803268}

  • Fixed the MySQL config.
  • Loaded any page, to put us "in flight".
  • Broke MySQL config.
  • Loaded any page.
  • Got the friendly "in flight" error page:

{F1803271}

If you want to design this better, easiest way to get to it is:

  • Set mysql.port to 9999 in conf/local/local.json.
  • Reload any page while already running (don't restart).

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11589

Differential Revision: https://secure.phabricator.com/D16503

Details

Committed
epriestley <git@epriestley.com>Sep 7 2016, 15:59
Pushed
aubortJan 31 2017, 17:16
Parents
rPH0e8ceeb69088: Continue on bad database configuration from select scripts
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHf82adbf0c8ff: Add a friendlier "in flight" error page (authored by epriestley <git@epriestley.com>).Sep 7 2016, 15:59