Homec4science

Convert DivinerLiveSymbol to text, not bytes

Authored by epriestley <git@epriestley.com> on Oct 1 2014, 19:10.

Description

Convert DivinerLiveSymbol to text, not bytes

Summary:
Ref T1191. The bytes types are BINARY(...), which is fixed-length and zero-pads. These hashes are not 64 characters long, so migrating them to binary ends up with a bunch of zero-padding.

Instead, migrate them to text so we drop the zero padding. It would be vaguely nice to either introduce a varbytes type (ick) or change the hash size to a standard size (nicer) eventually, but this isn't very important.

Test Plan: Will adjust secure.phabricator.com.

Reviewers: btrahan

Subscribers: epriestley

Maniphest Tasks: T1191

Differential Revision: https://secure.phabricator.com/D10613

Details

Committed
epriestley <git@epriestley.com>Oct 1 2014, 19:10
Pushed
aubortJan 31 2017, 17:16
Parents
rPH5ce3575fb534: Fix `adjust` phases for keys
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHf881b5dd7fe8: Convert DivinerLiveSymbol to text, not bytes (authored by epriestley <git@epriestley.com>).Oct 1 2014, 19:10