Homec4science

Make the paste creation form work on phones

Authored by epriestley <git@epriestley.com> on Aug 15 2012, 23:15.

Description

Make the paste creation form work on phones

Summary:
This is the first time I've ever had CSS actually work like it promises it does (i.e., markup the "right" way and then you don't have to change the markup later).

Since I laboriously laid this whole thing out with <divs> originally, I was able to just override some of the styles and make the layout reasonable for devices.

The only differences for existing forms are:

  • No colon after labels (looks cleaner anyway).
  • Non-error required text is no longer a red star but a the grey word "Required" (this is clearer).

Test Plan:
Viewed paste form on a phone.

Viewed ~20 other forms on the site to verify that I didn't break anything.

Reviewers: btrahan, chad, vrana

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1569

Differential Revision: https://secure.phabricator.com/D3298

Details

Committed
epriestley <git@epriestley.com>Aug 15 2012, 23:15
Pushed
aubortJan 31 2017, 17:16
Parents
rPHf5e738b7ca1c: Minor, fix a name collision between HeraldRuleController and…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHfa5a5a0a1235: Make the paste creation form work on phones (authored by epriestley <git@epriestley.com>).Aug 15 2012, 23:15