Homec4science

Stop all object mentions from matching after "@"

Authored by epriestley <git@epriestley.com> on Sep 29 2015, 15:43.

Description

Stop all object mentions from matching after "@"

Summary:
Fixes T9479. Currently, @aaaaaaaa may try to match as a commit hash, and @C123456 may try to match as a Countdown reference. These should only match as user mentions.

Prevent object mention rules from matching after @. We already prevent them after - and #, and already prevented the username rule after @ (i.e., preventing @@user).

Test Plan:
Created some "interesting" users locally and @mentioned them:

{F850779}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9479

Differential Revision: https://secure.phabricator.com/D14186

Details

Committed
epriestley <git@epriestley.com>Sep 29 2015, 15:43
Pushed
aubortJan 31 2017, 17:16
Parents
rPH21021b55c4d2: Update configuring_file_domain.diviner's cloudflare link
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHfa943f744bc4: Stop all object mentions from matching after "@" (authored by epriestley <git@epriestley.com>).Sep 29 2015, 15:43