Homec4science

Don't do image stuff with unviewable images

Authored by Edward Speyer <edward@fb.com> on Feb 6 2013, 22:43.

Description

Don't do image stuff with unviewable images

Summary: If a file isn't a viewable image, don't try to figure out metadata (size, etc.) when rendering a {F...} tag in Remarkup.

Test Plan: Uploaded a .rtf, added it as {F1} in a new Maniphest task, saw no errors in the dark console.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2479

Differential Revision: https://secure.phabricator.com/D4837

Details

Committed
Edward Speyer <edward@fb.com>Feb 6 2013, 22:43
Pushed
aubortJan 31 2017, 17:16
Parents
rPH361ce491f201: Make file storage more testable
Branches
Unknown
Tags
Unknown

Event Timeline

Edward Speyer <edward@fb.com> committed rPHfb7d5d17a2be: Don't do image stuff with unviewable images (authored by Edward Speyer <edward@fb.com>).Feb 6 2013, 22:43