Homec4science

Support key schemata and column nullability

Authored by epriestley <git@epriestley.com> on Sep 18 2014, 17:32.

Description

Support key schemata and column nullability

Summary:
Ref T1191. The major issue motivation here is that InnoDB keys have a maximum length of 767 bytes. When we move utf8 colums to utf8mb4 columns, they'll jump from 3 bytes per character to 4 bytes per character, which may make some indexes too long. Add key schema to help spot this.

Also add nullability since it doesn't hurt.

Test Plan: See screenshots.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T1191

Differential Revision: https://secure.phabricator.com/D10499

Details

Committed
epriestley <git@epriestley.com>Sep 18 2014, 17:32
Pushed
aubortJan 31 2017, 17:16
Parents
rPHaa481dba570d: Begin generating meaningful expected schemata
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHfb8da6f4afe5: Support key schemata and column nullability (authored by epriestley <git@epriestley.com>).Sep 18 2014, 17:32