Homec4science

Rebuild custom field indexes when rebuilding standard/fulltext search indexes

Authored by epriestley <git@epriestley.com> on Feb 10 2014, 23:32.

Description

Rebuild custom field indexes when rebuilding standard/fulltext search indexes

Summary:
Ref T4379. Fixes T4359. Currently, bin/search index does not rebuild CustomField indexes. This is because they aren't really part of the main search index. However, from a user's point of view this is by far the most logical place to look for index rebuilds, and it's straightforward for us to write into this secondary store.

At some point, it might be nice to let you specify fields as "fulltext" too, although no one has asked for that yet. We could then dump the text of those fields into the fulltext index. Ref T418.

Test Plan: Used bin/search index --type proj --trace, etc., and examination of the database to verify that indexes rebuilt. Reindexed users, tasks, projects.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4359, T418, T4379

Differential Revision: https://secure.phabricator.com/D8185

Details

Committed
epriestley <git@epriestley.com>Feb 10 2014, 23:32
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd70dd190e4e5: Make project profile picture edits transactional
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHfb9b023fbaaf: Rebuild custom field indexes when rebuilding standard/fulltext search indexes (authored by epriestley <git@epriestley.com>).Feb 10 2014, 23:32