Homec4science

Improve usability of Phrequent "Stop Time" dialog

Authored by epriestley <git@epriestley.com> on Aug 11 2014, 21:30.

Description

Improve usability of Phrequent "Stop Time" dialog

Summary:
Fixes T5848.

  • Disallow tracking negative time.
  • Preserve note if there's an error with the time selection.
  • Show start time and duration.
  • Slightly better error messages.

Test Plan: Started and stopped time. Tried to select future/negative ranges.

Reviewers: hach-que, btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T5848

Differential Revision: https://secure.phabricator.com/D10218

Details

Committed
epriestley <git@epriestley.com>Aug 11 2014, 21:30
Pushed
aubortJan 31 2017, 17:16
Parents
rPH31e1653a4e45: Convert `pushlog` and `refcursor` to BLOB storage
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHfc814647e60a: Improve usability of Phrequent "Stop Time" dialog (authored by epriestley <git@epriestley.com>).Aug 11 2014, 21:30