Homec4science

Be more strict with JSHint.

Authored by Joshua Spence <josh@joshuaspence.com> on Jun 22 2014, 20:07.

Description

Be more strict with JSHint.

Summary: Add a bunch of extra checks to be performed by jshint. For documentation, see http://jshint.com/docs/options/.

Test Plan:
Ran jshint --config support/jshint/jshintconfig webroot/rsrc/js/. There were a bunch of existing violations, but some of these are legitimate and probably require attention.

{
  "bitwise": true, // 0 violations
  "curly": true, // 0 violations
  "immed": true, // 1 violation
  "indent": 2, // 0 violations
  "latedef": true, // 10 violations
  "newcap": true, // 1 violation
  "noarg": true, // 0 violations
  "quotmark": "single", // 55 violations
  "undef": true, // 24 violations
  "unused": true, // 107 violations

  "expr": true,
  "loopfunc": true,
  "sub": true,

  "globals": {
    "JX": false,
    "__DEV__": false
  },
  "browser": true
}

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9659

Details

Committed
Joshua Spence <josh@joshuaspence.com>Jun 22 2014, 20:07
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe0191750cc97: Lint JSON files with `ArcanistJSONLinter`.
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rPHfcaeb2aeb6d9: Be more strict with JSHint. (authored by Joshua Spence <josh@joshuaspence.com>).Jun 22 2014, 20:07