Homec4science

ReleephRequest xactions

Authored by Edward Speyer <edward@fb.com> on Apr 8 2013, 17:34.

Description

ReleephRequest xactions

Summary:
Migrate to PhabricatorApplicationTransactions (ReleephRequestTransactions applied by ReleephRequestTransactionalEditor, instead of ReleephRequestEvents created by ReleephRequestEditor) and migrate all the old events into transactions. Email is supported in the standard way (no more ReleephRequestMail) as well.

This also collapses the Releeph request create and edit controllers into one class, as well as breaking everyone's subject-based mail rules by standardising them (but which should be more easily filtered by looking at headers.)

Test Plan:

  • Make requests, then pick them.
  • Pick and revert the same request so that discovery happens way after arc has told Releeph about what's been happening.
  • Try to pick something that fails to pick in a project with pick instructions (and see the instructions are in the email.)
  • Load all of FB's Releeph data into my DB and run the storage upgrade script.
  • Request a commit via the "action" in a Differential revision.

Reviewers: epriestley

Reviewed By: epriestley

CC: epriestley, aran, Korvin, wez

Maniphest Tasks: T3092, T2720

Differential Revision: https://secure.phabricator.com/D5868

Details

Committed
Edward Speyer <edward@fb.com>May 11 2013, 16:20
Pushed
aubortJan 31 2017, 17:16
Parents
rPH00cc6b1ba5ab: Double escape %N (%%N) for pht in Releeph project editor
Branches
Unknown
Tags
Unknown

Event Timeline

Edward Speyer <edward@fb.com> committed rPHfcb728653312: ReleephRequest xactions (authored by Edward Speyer <edward@fb.com>).May 11 2013, 16:20