Homec4science

Fix production file links for some alt-domain configurations

Authored by epriestley <git@epriestley.com> on Feb 16 2012, 02:06.

Description

Fix production file links for some alt-domain configurations

Summary:
We sometimes call PhabricatorEnv::getProductionURI($file->getBestURI()) or
similar, but this may currently cause us to construct a URI like this:

http://domain.com/http://cdn-domain.com/file/data/xxx/yyy/name.jpg

Instead, if the provided URI has a domain already, leave it unmodified.

Test Plan: Attached a file to a task; got an email with a valid URI instead of
an invalid URI.

Reviewers: btrahan

Reviewed By: btrahan

CC: Makinde, aran, epriestley

Differential Revision: https://secure.phabricator.com/D1622

Details

Committed
epriestley <git@epriestley.com>Feb 16 2012, 02:06
Pushed
aubortJan 31 2017, 17:16
Parents
rPH4bd336cedc75: Add a "group by priority" to the homepage revision query
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHfce6a7089cf3: Fix production file links for some alt-domain configurations (authored by epriestley <git@epriestley.com>).Feb 16 2012, 02:06