Clean up numerous rough edges in Mail configuration
fcf5149b3648
Actions

Authored by epriestley <git@epriestley.com> on Apr 22 2014, 00:45.

Description

Clean up numerous rough edges in Mail configuration

Summary:

Support file attachments in Mailgun, after D8831.
Fix bin/mail send-test --attach ... flag.
Make bin/mail send-test route mail through the daemons.
Remove the workerTaskID on MetaMTAMail, which is only used (needlessly) by bin/mail resend and creates a huge mess elsewhere.
Currently, when mail fails, the daemon exits with a very generic and useless message. Instead, make sendNow() throw when it fails, so the real reason is surfaced. This is OK now because mail is always sent via the daemons.
Now that Mailgun supports attachments, document it.
Update a bunch of mail docs.

Test Plan:

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Committed

epriestley <git@epriestley.com>

Apr 22 2014, 00:45

Pushed

aubort

Jan 31 2017, 17:16

Parents

Branches

Unknown

Tags

Unknown

epriestley <git@epriestley.com> committed rPHfcf5149b3648: Clean up numerous rough edges in Mail configuration (authored by epriestley <git@epriestley.com>).Apr 22 2014, 00:45

				Path
	M			resources/celerity/map.php
	M			src/applications/metamta/PhabricatorMetaMTAWorker.php
	M			src/applications/metamta/adapter/PhabricatorMailImplementationMailgunAdapter.php
	M			src/applications/metamta/management/PhabricatorMailManagementResendWorkflow.php
	M			src/applications/metamta/management/PhabricatorMailManagementSendTestWorkflow.php
	M			src/applications/metamta/storage/PhabricatorMetaMTAMail.php
	M			src/applications/metamta/storage/__tests__/PhabricatorMetaMTAMailTestCase.php
	M			src/docs/user/configuration/configuring_inbound_email.diviner
	M			src/docs/user/configuration/configuring_outbound_email.diviner