Homec4science

Don't copy `null` attributes passed to JX.$N()

Authored by epriestley <git@epriestley.com> on Sep 1 2015, 00:52.

Description

Don't copy null attributes passed to JX.$N()

Summary:
Fixes T8919. In Safari, node.href = null; has no effect, but in Chrome it is like node.href = "null";.

Instead, just use semantics similar to phutil_tag(): don't assign attributes with null values.

Test Plan:
No more /null href in Chrome in Owners typehaead.

Typeahead still works in Chrome/Safari.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T8919

Differential Revision: https://secure.phabricator.com/D14021

Details

Committed
epriestley <git@epriestley.com>Sep 1 2015, 00:52
Pushed
aubortJan 31 2017, 17:16
Parents
rPH9159c0e0017d: Update bar colors to match icon colors
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHfe66d52a22a5: Don't copy `null` attributes passed to JX.$N() (authored by epriestley <git@epriestley.com>).Sep 1 2015, 00:52