Homec4science

Improve DifferentialRevisionQuery and add the ability to query by arcanist…

Authored by epriestley <git@epriestley.com> on Apr 10 2012, 21:51.

Description

Improve DifferentialRevisionQuery and add the ability to query by arcanist project

Summary:

  • We currently post-filter by branches, but should do this in SQL. See T799.
  • We currently identify branch-name-matches as being in the working copy even if they belong to a different project (e.g., two different projects with commits on the branch "master"). See T1100.
  • Denormalize branch and project information into DifferentialRevision.
  • Expose project information in the API.

Test Plan: Ran conduit API queries with branches and arc project IDs, got reasonable results.

Reviewers: btrahan, vrana, jungejason

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1100, T799

Differential Revision: https://secure.phabricator.com/D2190

Details

Committed
epriestley <git@epriestley.com>Apr 10 2012, 21:51
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb5adde88d421: Simplify selecting authors and revisions in blame
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHfe9ba6bc67dd: Improve DifferentialRevisionQuery and add the ability to query by arcanist… (authored by epriestley <git@epriestley.com>).Apr 10 2012, 21:51