Homec4science

Pholio - robustify submission errors to retain image edits

Authored by Bob Trahan <bob.trahan@gmail.com> on Feb 11 2014, 20:38.

Description

Pholio - robustify submission errors to retain image edits

Summary: we should build all the image stuff on every post and use that posted image data if there's an error. this diff makes that so. Fixes T4380.

Test Plan: made a mock with no title, tried to save it, and was delighted to see my images still there. edited a mock - removing the title and adding images - verified edits showed up after erroneous submission. added a title and submitted and changes were saved.

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Maniphest Tasks: T4380

Differential Revision: https://secure.phabricator.com/D8197

Details

Committed
Bob Trahan <bob.trahan@gmail.com>Feb 11 2014, 20:38
Pushed
aubortJan 31 2017, 17:16
Parents
rPH305fb3fbd9c1: Migrate all Differential comment text into new storage
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <bob.trahan@gmail.com> committed rPHfec5ea8f9dac: Pholio - robustify submission errors to retain image edits (authored by Bob Trahan <bob.trahan@gmail.com>).Feb 11 2014, 20:38