Homec4science

Render the clone URI input field as readonly.

Authored by William R. Otte <wotte@isis.vanderbilt.edu> on Dec 20 2013, 20:47.

Description

Render the clone URI input field as readonly.

Summary:
There's no particular reason to allow the user to edit the clone URI field in Diffusion; editing it has no meaning and if you fat finger the keyboard, it's quite possible that the user will either accidentally clear and/or modify the URI before copying (bit me this morning).

Adding a readonly attribute to the input field allows the same benefit (URI is easily selectable) while preventing such accidental input. Fixes T4246.

Test Plan: Verified that the desired behavior is present in both Chrome, Safari, and Firefox. Field remains selectable with one click, but field is not editable.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Maniphest Tasks: T4246

Differential Revision: https://secure.phabricator.com/D7810

Details

Committed
William R. Otte <wotte@isis.vanderbilt.edu>Dec 20 2013, 20:47
Pushed
aubortJan 31 2017, 17:16
Parents
rPH134c8f554763: Add "Author" and "Committer" fields to Herald pre-commit content hooks
Branches
Unknown
Tags
Unknown

Event Timeline

William R. Otte <wotte@isis.vanderbilt.edu> committed rPHff13bb8538a2: Render the clone URI input field as readonly. (authored by William R. Otte <wotte@isis.vanderbilt.edu>).Dec 20 2013, 20:47