Homec4science

Reduce the total number of calls to getCallsign()

Authored by epriestley <git@epriestley.com> on Jan 2 2016, 02:34.

Description

Reduce the total number of calls to getCallsign()

Summary: Ref T4245. Before doing any hard work here, we can dramatically reduce the number of things that make calls to getCallsign() to make navigating things easier. Almost all of them only care about a monogram, URI, or display name.

Test Plan:

  • Searched for r uniquename in jump nav.
  • Ran bin/repository reparse --change rXXXyyyyy --trace, observed query against bad commit table.
  • Ran bin/search index rXXXyyyy --trace --force, observed proper title when indexing commit.
  • Browed repository list, saw proper rXXX and appropriate link targets.
  • Mentioned rXXX in Remarkup, got a link to the right place.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4245

Differential Revision: https://secure.phabricator.com/D14923

Details

Committed
epriestley <git@epriestley.com>Jan 2 2016, 13:23
Pushed
aubortJan 31 2017, 17:16
Parents
rPH45ccc930ec4a: Convert Badges to use EditEngine
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHff1bfb64dd56: Reduce the total number of calls to getCallsign() (authored by epriestley <git@epriestley.com>).Jan 2 2016, 13:23